JIT: Streamline TreeLifeUpdater #80611
Conversation
TreeLifeUpdater at most needs to flip 4 bits in two liveness sets when it is called, however before this change it uses several full width bitset operations to do this. This changes TreeLifeUpdater to do its job in a much more direct way by updating the liveness sets directly.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsTreeLifeUpdater at most needs to flip 4 bits in two liveness sets when it is called, however before this change it uses several full width bitset operations to do this. This changes TreeLifeUpdater to do its job in a much more direct way by updating the liveness sets directly.
|
| // TODO: Remove this condition which disallows marking | ||
| // some fields as dead even though they are dying when other | ||
| // fields are defined. |
There was a problem hiding this comment.
I will clean up these TODOs and unify some of these cases in #80501.
|
cc @dotnet/jit-contrib PTAL @BruceForstall No ASM diffs but around -1% throughput improvement on optimized collections. The review might not be that easy as much of the logic was reworked and restructured. The old logic was using several temporary bit sets ( Will run some stress jobs too. |
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-coreclr gcstress0x3-gcstress0xc, runtime-coreclr jitstressregs |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
GC stress failures are unrelated and will be fixed by #80630. |
|
I can reproduce the libraries-jitstress failure on main too so it also seems to be unrelated. Will try to bisect it and open an issue. Edit: Opened #80632. |
|
Ping @BruceForstall |
TreeLifeUpdater at most needs to flip 4 bits in two liveness sets when it is called, however before this change it uses several full width bitset operations to do this. This changes TreeLifeUpdater to do its job in a much more direct way by updating the liveness sets directly.
ghost
locked as resolved and limited conversation to collaborators
2 participants
TreeLifeUpdater at most needs to flip 4 bits in two liveness sets when it is called, however before this change it uses several full width bitset operations to do this. This changes TreeLifeUpdater to do its job in a much more direct way by updating the liveness sets directly.