Lowercase TargetOS #80164
Merged
Lowercase TargetOS #80164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
/azp list |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ViktorHofer
force-pushed
the
LowercaseTargetOS
branch
from
01a49fd to
524c43b
Compare
ViktorHofer
force-pushed
the
LowercaseTargetOS
branch
3 times, most recently
from
376ad4c to
acff22e
Compare
This was referenced Jan 10, 2023
ViktorHofer
force-pushed
the
LowercaseTargetOS
branch
from
acff22e to
49a254c
Compare
ViktorHofer
requested review from
MichalStrehovsky,
SamMonoRT,
lambdageek,
lewing,
marek-safar,
pavelsavara,
radical,
thaystg and
vargaz
as code owners
akoeplinger
approved these changes
Jan 11, 2023
akoeplinger
approved these changes
Jan 11, 2023
|
Just updated my local main:
I assume it needs |
|
Sorry for the inconvenience and thanks for reporting. Just submitted a fix: #80544 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #32451 (comment)
Follow-up on #80074
In #43651, the "Windows" OS name was lowercased to achieve target frameworks with RIDs in them. At that time, the original plan was to lowercase all TargetOS values but that had to be cut because of resources. This PR finishes that and updates build systems, YML, markdowns and managed components.
To not break existing developer workflows, the passed-in
-osvalue is automatically lower-cased in the script entry points and validated in the msbuild entry point.This change was performed via
<OS>-><os>for all the possible OS values that we support (i.e. Browser -> browser) in msbuild, cmake, docs, etc.