Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Revert back to using latest stable versions of chrome for testing #80135

Merged
merged 2 commits into from
Jan 3, 2023
Merged

[wasm] Revert back to using latest stable versions of chrome for testing #80135

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c629b3
[wasm] Revert back to using latest stable versions of chrome for testing
radical Jan 3, 2023
926a0cd
[wasm] widen the search area for chrome snapshots. They seem to be le…
radical Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion eng/testing/ProvisioningVersions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

Refer to `GetChromeVersions` task in `src/tasks` to see how we find
these snapshot urls.
-->

<PropertyGroup Label="Use specific version of chrome" Condition="$([MSBuild]::IsOSPlatform('linux'))">
<ChromeVersion>107.0.5304.110</ChromeVersion>
<ChromeRevision>1047731</ChromeRevision>
Expand All @@ -51,6 +51,8 @@
<_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1047737</_ChromeBaseSnapshotUrl>
</PropertyGroup>

-->

<PropertyGroup Condition="'$(BrowserHost)' != 'windows'">
<FirefoxRevision>108.0.1</FirefoxRevision>
<FirefoxUrl>https://ftp.mozilla.org/pub/firefox/releases/$(FirefoxRevision)/linux-x86_64/en-US/firefox-$(FirefoxRevision).tar.bz2</FirefoxUrl>
Expand Down
3 changes: 2 additions & 1 deletion src/tasks/WasmBuildTasks/GetChromeVersions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ private async Task<string> GetChromeUrlsAsync(ChromeVersionSpec version)

throw new LogAsErrorException($"Could not find a chrome snapshot folder under {baseUrl}, " +
$"for branch positions {version.branch_base_position} to " +
$"{branchPosition}, for version {version.version}.");
$"{branchPosition}, for version {version.version}. " +
"A fixed version+url can be set in eng/testing/ProvisioningVersions.props .");
}

private async Task<ChromeVersionSpec> GetChromeVersionAsync()
Expand Down