Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullable annotations in ITypedList #80033

Merged
merged 1 commit into from
Jan 8, 2023

Conversation

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 29, 2022
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Dec 29, 2022

Tagging subscribers to this area: @dotnet/area-system-componentmodel
See info in area-owners.md if you want to be subscribed.

Issue Details

According to:
https://learn.microsoft.com/en-us/dotnet/api/system.componentmodel.itypedlist.getitemproperties
https://learn.microsoft.com/en-us/dotnet/api/system.componentmodel.itypedlist.getlistname
the parameters can be null.
I bumped into this problem while annotating ListBindingHelper in WinForms repository.
https://github.com/dotnet/winforms/blob/bc73fc2790fdce8ac7399eddf76824161bdd35cc/src/System.Windows.Forms/src/System/Windows/Forms/ListBindingHelper.cs

Author: gpetrou
Assignees: -
Labels:

area-System.ComponentModel, new-api-needs-documentation, community-contribution

Milestone: -

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@stephentoub stephentoub merged commit 339a204 into dotnet:main Jan 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.ComponentModel community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants