Fix the ARM's double register name displayed in JitDisasm/JitDump
#79949
Conversation
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
@dotnet/jit-contrib |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsFix the display of ARM double register name in JitDisasm and JitDump. We would just display the floating register name, but instead should be displaying the accurate double register name (that the encoding reflects). Fixes: #8121
|
| } | ||
| else | ||
| { | ||
| printf("s%s", emitFloatRegName(reg, attr) + 1); |
There was a problem hiding this comment.
Is this side also incorrect? I could easily have misread the chain of calls, but it looked like emitFloatRegName is going to return "f" so it would be "sf", which doesn't seem right.
There was a problem hiding this comment.
Right, but since we do + 1, we remove the extra f character that gets printed. This portion is unchanged actually.
There was a problem hiding this comment.
I will just use something manual version of _itoa to convert from int -> string.
Fix the display of ARM double register name in JitDisasm and JitDump. We would just display the floating register name, but instead should be displaying the accurate double register name (that the encoding reflects).
Fixes: #8121