Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix numbering of exposed LCL_VARs #79772

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Fix numbering of exposed LCL_VARs #79772

merged 4 commits into from
Jan 11, 2023

Commits on Dec 16, 2022

  1. Fix numbering of exposed LCL_VARs 

    The conservative VN must be unique for different uses lest
we risk running into memory safety issues, by, e. g. removing
range checks based on "racy" data.
    @SingleAccretion
    SingleAccretion committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    bfa03b2 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2022

  1. Add a test 

    Without the fix, 4 out of 5 runs fail on my machine.
    @SingleAccretion
    SingleAccretion committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    51a7310 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Succeed the test on platforms without threads 

    No threading => no races.
    @SingleAccretion
    SingleAccretion committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    6588ac5 View commit details
    Browse the repository at this point in the history

  2. Disable on Mono interp

    @SingleAccretion
    SingleAccretion committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    feee081 View commit details
    Browse the repository at this point in the history