-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Roslyn support for RuntimeHelpers.CreateSpan (or field caching downlevel) #79461
Conversation
Tagging subscribers to this area: @dotnet/area-meta Issue Detailsnull
|
src/libraries/System.IO.Compression/src/System/IO/Compression/DeflateManaged/InflaterManaged.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/JsonHelpers.Date.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/JsonHelpers.Date.cs
Outdated
Show resolved
Hide resolved
Some compiler fixes in dotnet/roslyn#65919. |
62711ef
to
f4ed220
Compare
FYI, resolved the conflict |
463f363
to
75b01ab
Compare
aa8488f
to
89adf99
Compare
Just curious - is it blocked by some other roslyn/illink bug currently? Can't wait to see it merged 🙂 |
Yes, it's blocked by a cecil / illink bug that's resulting in some fields being misaligned. |
@sbomer, any updated ETA on when you think a fix might land? Thanks! |
@stephentoub #79449 is the last blocker |
Excellent, thanks. |
7e090d8
to
9a818ef
Compare
This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that DaysToMonth365
and DaysToMonth366
are duplicated in several files but I assume it's not a big deal
This PR isn't adding any duplication. It removes some of the duplication already there, and then what's left remains duplicated because they're either defined in different assemblies or using different types. We could obviously reduce that source duplication by putting them in a shared file, but I chose not to do so as part of this PR. |
@sbomer, this is still hitting an alignment issue, on both x86 and arm64 legs 😦
Is this somehow not picking up your fixes? Are there more issues lurking? |
8fc73a7
to
0eb88a4
Compare
#79449 hasn't merged yet. |
Thanks. 🤦♂️ Somehow I saw the link as the larger dependency update that did merge; too many tabs open I guess. Will try again now that it has merged. |
No description provided.