Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JIT] X64 - Extend emitter peephole optimization of eliminating unnecessary mov instructions #79381

Merged
merged 88 commits into from
Feb 25, 2023
Merged

[JIT] X64 - Extend emitter peephole optimization of eliminating unnecessary mov instructions #79381

merged 88 commits into from
Feb 25, 2023

Commits on Dec 7, 2022

  1. Added regUpper32BitsZeroLookup

    @TIHan
    TIHan committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    f5feaeb View commit details
    Browse the repository at this point in the history

  2. Minor refactoring

    @TIHan
    TIHan committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    958a84f View commit details
    Browse the repository at this point in the history

  3. Refactoring

    @TIHan
    TIHan committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    755461e View commit details
    Browse the repository at this point in the history

  4. Refactoring

    @TIHan
    TIHan committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    95c7d09 View commit details
    Browse the repository at this point in the history

  5. Refactoring

    @TIHan
    TIHan committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    12e3c4f View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Added comments, more refactoring

    @TIHan
    TIHan committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    b42682c View commit details
    Browse the repository at this point in the history

  2. Added some logs

    @TIHan
    TIHan committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2d806a5 View commit details
    Browse the repository at this point in the history

  3. Added some logs

    @TIHan
    TIHan committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2d5e07f View commit details
    Browse the repository at this point in the history

  4. Added some logs

    @TIHan
    TIHan committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    4d06e05 View commit details
    Browse the repository at this point in the history

  5. Added some logs

    @TIHan
    TIHan committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    0c1599a View commit details
    Browse the repository at this point in the history

  6. Remove logs. Fixed an issue.

    @TIHan
    TIHan committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    53ecd41 View commit details
    Browse the repository at this point in the history

  7. Expanding peephole opt even more. Trying to improve tp.

    @TIHan
    TIHan committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    0f42667 View commit details
    Browse the repository at this point in the history

  8. Some refactoring

    @TIHan
    TIHan committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2de6089 View commit details
    Browse the repository at this point in the history

  9. Trying to make this safe

    @TIHan
    TIHan committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    bd3b211 View commit details
    Browse the repository at this point in the history

  10. work

    @TIHan
    TIHan committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    9792d0f View commit details
    Browse the repository at this point in the history

  11. more work

    @TIHan
    TIHan committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    0ed30e9 View commit details
    Browse the repository at this point in the history

  12. Fixing a few issues

    @TIHan
    TIHan committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3e452fd View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Fixing a bug

    @TIHan
    TIHan committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    126d6b5 View commit details
    Browse the repository at this point in the history

  2. Switching to a list of instrs

    @TIHan
    TIHan committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    80ac0d7 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2022

  1. Adding simple peephole API

    @TIHan
    TIHan committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    9497d5e View commit details
    Browse the repository at this point in the history

  2. minor change

    @TIHan
    TIHan committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    4ee489b View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2022

  1. Trying to improve tp

    @TIHan
    TIHan committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    7d599df View commit details
    Browse the repository at this point in the history

  2. Trying to improve tp

    @TIHan
    TIHan committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    11a1709 View commit details
    Browse the repository at this point in the history

  3. Fixed a minor issue

    @TIHan
    TIHan committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    e33147a View commit details
    Browse the repository at this point in the history

  4. Small correctness issue

    @TIHan
    TIHan committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    99cba5a View commit details
    Browse the repository at this point in the history

  5. Minor change

    @TIHan
    TIHan committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    0356348 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. Using emitCurIGinsCnt

    @TIHan
    TIHan committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    2c10d21 View commit details
    Browse the repository at this point in the history

  2. Added EMIT_MAX_IG_INS_COUNT

    @TIHan
    TIHan committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    189afe0 View commit details
    Browse the repository at this point in the history

  3. Formatting

    @TIHan
    TIHan committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    f0e626a View commit details
    Browse the repository at this point in the history

  4. Feedback

    @TIHan
    TIHan committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    f1e7c07 View commit details
    Browse the repository at this point in the history

  5. Feedback

    @TIHan
    TIHan committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    ca8813a View commit details
    Browse the repository at this point in the history

  6. Feedback

    @TIHan
    TIHan committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    c533d54 View commit details
    Browse the repository at this point in the history

  7. Minor change

    @TIHan
    TIHan committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    e0df38e View commit details
    Browse the repository at this point in the history

  8. More comments, minor change

    @TIHan
    TIHan committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    1f5501a View commit details
    Browse the repository at this point in the history

  9. Get rid of these asserts

    @TIHan
    TIHan committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    e34367f View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Improving TP even further

    @TIHan
    TIHan committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    b2c0414 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Added CalculateChecksumTest

    @TIHan
    TIHan committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    5431a53 View commit details
    Browse the repository at this point in the history

  2. Only allow GPR

    @TIHan
    TIHan committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    07ec7fb View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Update src/coreclr/jit/emitxarch.cpp 

    Co-authored-by: Bruce Forstall <[email protected]>
    @TIHan @BruceForstall
    TIHan and BruceForstall authored Jan 6, 2023
    Configuration menu
    Copy the full SHA
    7e0079f View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2023

  1. Feedback

    @TIHan
    TIHan committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    0c71902 View commit details
    Browse the repository at this point in the history

  2. Feedback

    @TIHan
    TIHan committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    25cb4fb View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Merge remote-tracking branch 'upstream/main' into mov-elim-1

    @TIHan
    TIHan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    7d6d03d View commit details
    Browse the repository at this point in the history

  2. Updating last instructions when saving IG. Using 'min(emitCurIGinsCnt… 

    …, EMIT_MAX_LAST_INS_COUNT)' when iterating last instructions.
    @TIHan
    TIHan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    ee349d3 View commit details
    Browse the repository at this point in the history

  3. Added 'emitCurLastInsCnt'

    @TIHan
    TIHan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    a2538ca View commit details
    Browse the repository at this point in the history

  4. Remove commented code

    @TIHan
    TIHan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    6fb2694 View commit details
    Browse the repository at this point in the history

  5. Using 'emitCurLastInsCnt' for the ring buffer

    @TIHan
    TIHan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    7e97320 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Formatting

    @TIHan
    TIHan committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    896a32a View commit details
    Browse the repository at this point in the history

  2. Fix last instructions if the next IG is extended

    @TIHan
    TIHan committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    49c3c07 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Update emit.cpp

    @TIHan
    TIHan authored Jan 12, 2023
    Configuration menu
    Copy the full SHA
    f229bc0 View commit details
    Browse the repository at this point in the history

  2. Update emit.cpp

    @TIHan
    TIHan authored Jan 12, 2023
    Configuration menu
    Copy the full SHA
    920fc7c View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Merged

    @TIHan
    TIHan committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    7380971 View commit details
    Browse the repository at this point in the history

  2. Fix build

    @TIHan
    TIHan committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    a4e92c7 View commit details
    Browse the repository at this point in the history

  3. Fix build

    @TIHan
    TIHan committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    fa4f6e5 View commit details
    Browse the repository at this point in the history

  4. Fix build

    @TIHan
    TIHan committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    0fd25ca View commit details
    Browse the repository at this point in the history

  5. Formatting

    @TIHan
    TIHan committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    2ff99ed View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Fix assertion

    @TIHan
    TIHan committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    d2307d5 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. merging

    @TIHan
    TIHan committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    f478d53 View commit details
    Browse the repository at this point in the history

  2. Fixed minor issue

    @TIHan
    TIHan committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    0afbc01 View commit details
    Browse the repository at this point in the history

  3. Merging complete

    @TIHan
    TIHan committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    140fd11 View commit details
    Browse the repository at this point in the history

  4. Fix build

    @TIHan
    TIHan committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    423a72f View commit details
    Browse the repository at this point in the history

  5. Added canPeepholeCrossIGBoundaries

    @TIHan
    TIHan committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    c6c5711 View commit details
    Browse the repository at this point in the history

  6. Cleanup

    @TIHan
    TIHan committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    cab9705 View commit details
    Browse the repository at this point in the history

  7. More cleanup

    @TIHan
    TIHan committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    987e50c View commit details
    Browse the repository at this point in the history

  8. More cleanup

    @TIHan
    TIHan committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    453e00b View commit details
    Browse the repository at this point in the history

  9. More cleanup

    @TIHan
    TIHan committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    710b039 View commit details
    Browse the repository at this point in the history

  10. More cleanup

    @TIHan
    TIHan committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    cadbf4d View commit details
    Browse the repository at this point in the history

  11. More cleanup

    @TIHan
    TIHan committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    a68cd3f View commit details
    Browse the repository at this point in the history

  12. Fix build

    @TIHan
    TIHan committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    26cb484 View commit details
    Browse the repository at this point in the history

  13. Add count back

    @TIHan
    TIHan committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    a88103a View commit details
    Browse the repository at this point in the history

  14. Formatting

    @TIHan
    TIHan committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    5fe41e2 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Merge remote-tracking branch 'upstream/main' into mov-elim-1

    @TIHan
    TIHan committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    c1b612f View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Merge branch 'main' into mov-elim-1

    @TIHan
    TIHan authored Feb 15, 2023
    Configuration menu
    Copy the full SHA
    9f42790 View commit details
    Browse the repository at this point in the history

  2. Added back comments

    @TIHan
    TIHan committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    84f076c View commit details
    Browse the repository at this point in the history

  3. Turn off backwards nav for arm

    @TIHan
    TIHan committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    12ea52f View commit details
    Browse the repository at this point in the history

  4. Added debug check for backward nav checks

    @TIHan
    TIHan committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    cb3b2e8 View commit details
    Browse the repository at this point in the history

  5. Remove debug check

    @TIHan
    TIHan committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    a007c3b View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into mov-elim-1

    @TIHan
    TIHan committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    5e33fad View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Feedback. Allow looking back at conditional ops.

    @TIHan
    TIHan committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    b35c10e View commit details
    Browse the repository at this point in the history

  2. Update src/coreclr/jit/emit.h 

    Co-authored-by: Bruce Forstall <[email protected]>
    @TIHan @BruceForstall
    TIHan and BruceForstall authored Feb 22, 2023
    Configuration menu
    Copy the full SHA
    7576c94 View commit details
    Browse the repository at this point in the history

  3. Feedback

    @TIHan
    TIHan committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    6816216 View commit details
    Browse the repository at this point in the history

  4. Feedback

    @TIHan
    TIHan committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    3a4adfb View commit details
    Browse the repository at this point in the history

  5. Fix ordering

    @TIHan
    TIHan committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    5a3acc5 View commit details
    Browse the repository at this point in the history

  6. Added regression test. div,idiv,mul,imul should be noted as write to … 

    …ops.
    @TIHan
    TIHan committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    d48e429 View commit details
    Browse the repository at this point in the history

  7. Added another regression test

    @TIHan
    TIHan committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    90479c5 View commit details
    Browse the repository at this point in the history

  8. Actually added the regression test

    @TIHan
    TIHan committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    f7224c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Fix test

    @TIHan
    TIHan committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    36ffb3a View commit details
    Browse the repository at this point in the history

  2. Merged

    @TIHan
    TIHan committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    d1d7814 View commit details
    Browse the repository at this point in the history

  3. Fix merge

    @TIHan
    TIHan committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    8162a38 View commit details
    Browse the repository at this point in the history