Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't embed bitcode on tvOS anymore #79349

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Don't embed bitcode on tvOS anymore #79349

merged 3 commits into from
Dec 9, 2022

Conversation

filipnavara
Copy link
Member

Apple effectively deprecated bitcode embedding with Xcode 14 and no longer requires it for App Store submissions.

https://developer.apple.com/documentation/Xcode-Release-Notes/xcode-14-release-notes:

Starting with Xcode 14, bitcode is no longer required for watchOS and tvOS applications, and the App Store no longer accepts bitcode submissions from Xcode 14.

Xcode no longer builds bitcode by default and generates a warning message if a project explicitly enables bitcode: “Building with bitcode is deprecated. Please update your project and/or target settings to disable bitcode.” The capability to build with bitcode will be removed in a future Xcode release. IPAs that contain bitcode will have the bitcode stripped before being submitted to the App Store. Debug symbols can only be downloaded from App Store Connect / TestFlight for existing bitcode submissions and are no longer available for submissions made with Xcode 14. (86118779)

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 7, 2022
@filipnavara filipnavara mentioned this pull request Dec 7, 2022
Merged
rolfbjarne
rolfbjarne approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@rolfbjarne rolfbjarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should shrink the runtime pack significantly!

@filipnavara filipnavara marked this pull request as ready for review December 7, 2022 19:07
@build-analysis build-analysis bot mentioned this pull request Dec 7, 2022
Closed
@MichalStrehovsky
Copy link
Member

We can also undo the ifdef from #79322.

@filipnavara
Copy link
Member Author

We can also undo the ifdef from #79322.

Done

@steveisok steveisok self-requested a review December 8, 2022 11:49
steveisok
steveisok approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@build-analysis build-analysis bot mentioned this pull request Dec 8, 2022
Closed
@build-analysis build-analysis bot mentioned this pull request Dec 9, 2022
Closed
@marek-safar marek-safar merged commit 7cecd48 into dotnet:main Dec 9, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2023
@filipnavara filipnavara deleted the no-bitcode branch May 31, 2023 07:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky left review comments

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@steveisok steveisok steveisok approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees
No one assigned
Labels
area-Build-mono community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@filipnavara @MichalStrehovsky @rolfbjarne @steveisok @marek-safar