[mono] Add a managed cache for flags in RuntimeType. #78840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fix: |
marek-safar
reviewed
Nov 25, 2022
| { | ||
| TypeCache cache = Cache; | ||
| if ((cache.Cached & (int)TypeCacheEntries.TypeAttributes) != 0) | ||
| return cache.TypeAttributes; |
There was a problem hiding this comment.
Is this going to work with hot-reload?
There was a problem hiding this comment.
If hot reload can change the information that is cached here, then we need a way to either disable this, or a way to invalidate the cache. There is already a cache with some entries which could be affected by this.
There was a problem hiding this comment.
There's an issue #50978 to add a MetadataUpdateHandler for mono to clear reflection caches. (we also have caching in native that we need to clear, and that's not done yet, too). /cc @fanyang-mono
This was referenced Nov 29, 2022
lambdageek
approved these changes
Dec 9, 2022
|
Significant size improvement in Blazorwasm sample app
|
|
Not sure that its related to this PR. |
This was referenced Dec 14, 2022
This was referenced Jan 10, 2023
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.