Use IndexOfAnyValues in Xml #78664
Merged
Use IndexOfAnyValues in Xml #78664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-xml Issue DetailsContributes to #78204
|
MihaZupan
commented
Nov 22, 2022
src/libraries/System.Private.DataContractSerialization/src/System/Xml/XmlBaseWriter.cs
Show resolved
Hide resolved
tarekgh
reviewed
Nov 22, 2022
src/libraries/System.Private.DataContractSerialization/src/System/Xml/XmlConverter.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Nov 22, 2022
src/libraries/System.Private.DataContractSerialization/src/System/Xml/XmlConverter.cs
Outdated
Show resolved
Hide resolved
gfoidl
reviewed
Nov 22, 2022
src/libraries/System.Private.DataContractSerialization/src/System/Xml/XmlConverter.cs
Show resolved
Hide resolved
stephentoub
reviewed
Nov 22, 2022
| @@ -30,6 +30,10 @@ internal static class XmlConverter | |||
| public const int MaxUInt64Chars = 32; | |||
| public const int MaxPrimitiveChars = MaxDateTimeChars; | |||
|
|
|||
| // Matches IsWhitespace below | |||
| private static readonly IndexOfAnyValues<char> s_whitespaceChars = IndexOfAnyValues.Create(" \t\r\n"); | |||
| private static readonly IndexOfAnyValues<byte> s_whitespaceBytes = IndexOfAnyValues.Create(" \t\r\n"u8); | |||
There was a problem hiding this comment.
IndexOfAnyValues.Create and u8 go nicely together.
stephentoub
reviewed
Nov 22, 2022
src/libraries/System.Private.DataContractSerialization/src/System/Xml/XmlConverter.cs
Show resolved
Hide resolved
stephentoub
reviewed
Nov 22, 2022
src/libraries/System.Private.DataContractSerialization/src/System/Xml/XmlConverter.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Nov 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #78204