Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vector<T> != operator #78177

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Fix Vector<T> != operator #78177

merged 1 commit into from
Nov 11, 2022

Conversation

radekdoulik
Copy link
Member

Also fixes #78163

@ghost ghost assigned radekdoulik Nov 10, 2022
@ghost
Copy link

ghost commented Nov 10, 2022

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Also fixes #78163

Author: radekdoulik
Assignees: -
Labels:

area-System.Numerics
Milestone: -

@dakersnar
Copy link
Contributor

dakersnar commented Nov 10, 2022 •
edited
Loading

This is closely related to the fix we merged here: #77815. Are there any other locations that might need this fix?

Edit: I think not. Vector128, 256, and 512 all use Vector64's implementation. This PR should be the last change needed to fully fix this bug.

@radekdoulik radekdoulik mentioned this pull request Nov 10, 2022
Closed
@hughbe
Copy link
Contributor

hughbe commented Nov 10, 2022

surprised there isn't a test for this?

@filipnavara
Copy link
Member

surprised there isn't a test for this?

#77815 (comment) 😅

@hughbe
Copy link
Contributor

hughbe commented Nov 10, 2022

Ah... well I think we should also have some deterministic tests IMO

@tannergooding
Copy link
Member

Ah... well I think we should also have some deterministic tests IMO

We were supposed to have some hard coded tests to cover edges like this, but it looks like they never got checked in.

I'll log an issue and track getting this all audited/fixed.

@radekdoulik radekdoulik merged commit e319104 into dotnet:main Nov 11, 2022
@kotlarmilos kotlarmilos mentioned this pull request Nov 16, 2022
Closed
@BruceForstall
Copy link
Member

Does this need to get back-ported to 7?

@tannergooding
Copy link
Member

No, this was a .NET 8 exclusive change.

@lewing lewing mentioned this pull request Nov 22, 2022
Open
@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

@dakersnar dakersnar dakersnar approved these changes

Assignees

@radekdoulik radekdoulik

Labels
area-System.Numerics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mono] Performance regression in many places caused by #77562
6 participants
@radekdoulik @dakersnar @hughbe @filipnavara @tannergooding @BruceForstall