-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Vector<T> != operator #78177
Fix Vector<T> != operator #78177
Conversation
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsAlso fixes #78163
|
This is closely related to the fix we merged here: #77815. Are there any other locations that might need this fix? Edit: I think not. Vector128, 256, and 512 all use Vector64's implementation. This PR should be the last change needed to fully fix this bug. |
surprised there isn't a test for this? |
|
Ah... well I think we should also have some deterministic tests IMO |
We were supposed to have some hard coded tests to cover edges like this, but it looks like they never got checked in. I'll log an issue and track getting this all audited/fixed. |
Does this need to get back-ported to 7? |
No, this was a .NET 8 exclusive change. |
Also fixes #78163