Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[wasm] browser profiler (#77449)" #77759

Merged
merged 1 commit into from
Nov 2, 2022

Commits on Nov 1, 2022

  1. Revert "[wasm] browser profiler (dotnet#77449)"

    This reverts commit 0e24ea7.
    
    This breaks with v8 10.9.130 with:
    ```
    Error: Invalid 'startMark' argument: No numeric 'startTime' field
        at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
        at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
    exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
    ```
    
    It works fine with older versions like `10.7.193` (current stable).
    radical committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    2289b5b View commit details
    Browse the repository at this point in the history