Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Produce crashreport.json and use llvm-symbolizer to create stack trace #77578

Merged
merged 52 commits into from
Jan 27, 2023
Merged

Produce crashreport.json and use llvm-symbolizer to create stack trace #77578

merged 52 commits into from
Jan 27, 2023

Conversation

kunalspathak
Copy link
Member

@kunalspathak kunalspathak commented Oct 28, 2022 •
edited
Loading

Contributes to #75243 and #77918

@kunalspathak kunalspathak added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Oct 28, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 28, 2022
@ghost ghost assigned kunalspathak Oct 28, 2022
@ghost
Copy link

ghost commented Oct 28, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: kunalspathak
Assignees: -
Labels:

NO-MERGE, NO-REVIEW, area-CodeGen-coreclr
Milestone: -

This was referenced Oct 31, 2022
Closed
Closed
@kunalspathak kunalspathak mentioned this pull request Nov 4, 2022
Closed
3 tasks
@kunalspathak kunalspathak added area-Infrastructure-coreclr and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Dec 6, 2022
@ghost
Copy link

ghost commented Dec 6, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #75243 and #77918

Author: kunalspathak
Assignees: kunalspathak
Labels:

area-Infrastructure-coreclr
Milestone: -

@kunalspathak
Copy link
Member Author

Ping @hoyosjs

@hoyosjs
Copy link
Member

hoyosjs commented Dec 8, 2022

Will try to take a look between today and tomorrow.

@kunalspathak
Copy link
Member Author

Ping @hoyosjs

@agocke
Copy link
Member

agocke commented Dec 14, 2022

How will this work on systems like Alpine (musl) where we don't have dotnet installed on the machine, and the .NET runtime being tested is presumably broken?

@kunalspathak
Copy link
Member Author

It won't. This is just for Ubuntu x64 (for now).

agocke
agocke reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider writing some unit tests for this. There;s no reason why we can't manually create a crashing process and ensure this works.

src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs Outdated Show resolved Hide resolved
src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs Show resolved Hide resolved
src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs Outdated Show resolved Hide resolved
src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs Outdated Show resolved Hide resolved
src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs Outdated Show resolved Hide resolved
src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs Outdated Show resolved Hide resolved
src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs Show resolved Hide resolved
@kunalspathak
Copy link
Member Author

I'd consider writing some unit tests for this.

I am not sure if we have an infrastructure/existing test cases to test any of this code. @hoyosjs do we?

@agocke
Copy link
Member

agocke commented Dec 15, 2022

If we don't have infrastructure for testing this I think we need to make it. This code is supposed to be robust exactly in the edge cases where we won't get a lot of coverage. Testing a few simple cases and in PRs won't cut it.

@kunalspathak
Copy link
Member Author

If we don't have infrastructure for testing this I think we need to make it.

I agree, but I don't have bandwidth to do it this week. If we want, we can have this PR open until January when I can start looking at how to test it.

@agocke
Copy link
Member

agocke commented Dec 15, 2022

Sounds good, I don't think there's a rush to get this in this year. I'd rather do it right

@build-analysis build-analysis bot mentioned this pull request Dec 15, 2022
Closed
agocke
agocke approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's follow-up with unit tests when we have time to schedule it

src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs
string userName = Environment.GetEnvironmentVariable("USER");
if (!string.IsNullOrEmpty(userName))
{
if (!RunProcess("sudo", $"chown {userName} {crashReportJsonFile}"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If elevating works on Mac right now, that's great, but I could see this not working forever, so we should give a little thought to what we would do instead.

@kunalspathak kunalspathak merged commit ff987dc into dotnet:main Jan 27, 2023
@kunalspathak kunalspathak deleted the merge-on-red branch January 27, 2023 07:44
@eerhardt eerhardt mentioned this pull request Jan 30, 2023
Closed
agocke added a commit that referenced this pull request Jan 30, 2023
@agocke
Revert "Produce crashreport.json and use llvm-symbolizer to create st…
6b6659a 
…ack trace (#77578)"

This reverts commit ff987dc.
kunalspathak added a commit to kunalspathak/runtime that referenced this pull request Jan 30, 2023
@kunalspathak
Revert "Produce crashreport.json and use llvm-symbolizer to create st…
7e0d01d 
…ack trace (dotnet#77578)"

This reverts commit ff987dc.
@kunalspathak kunalspathak mentioned this pull request Jan 30, 2023
Merged
kunalspathak added a commit that referenced this pull request Jan 30, 2023
@kunalspathak
Revert "Produce crashreport.json and use llvm-symbolizer to create st…
3c76e14 
…ack trace (#77578)" (#81379)

This reverts commit ff987dc.
kunalspathak added a commit to kunalspathak/runtime that referenced this pull request Jan 30, 2023
@kunalspathak
Revert "Revert "Produce crashreport.json and use llvm-symbolizer to c…
bada32b 
…reate stack trace (dotnet#77578)" (dotnet#81379)"

This reverts commit 3c76e14.
kunalspathak added a commit that referenced this pull request Jan 31, 2023
@kunalspathak
Re-enable producing call stack from crashreport.json (#81387)
efb1df1 
* Revert "Revert "Produce crashreport.json and use llvm-symbolizer to create stack trace (#77578)" (#81379)"

This reverts commit 3c76e14.

* Add nativeSymbols only for PRs
@ghost ghost locked as resolved and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hoyosjs hoyosjs hoyosjs left review comments

@agocke agocke agocke approved these changes

Assignees

@kunalspathak kunalspathak

Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kunalspathak @hoyosjs @agocke