-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Use generated runtime.json when building shared framework packages (backport of #76068) #77510
[release/6.0] Use generated runtime.json when building shared framework packages (backport of #76068) #77510
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #76068 Per @tmds
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we need a servicing template and an approval from Tactics.
I don't think that this change is complete. Does the Microsoft.NETCore.Platforms library build outside of the -allconfigurations leg? We need it to produce the runtime.json file in all legs. |
I wouldn't know, I just backported and tested within installer pipelines + Alpine's source-build, and it seems like everything flows. @tmds do you have any insight on this? |
If these changes are sufficient, then this LGTM |
Approved by Tactics. Signed off by area owner. CI is green. Ready to merge. |
Backport of #76068
Per @tmds
Customer impact
Allows for proper fllow of additional runtime identifiers, allowing builds on yet-to-be-introduced RIDs to pass
Testing
Risk
Low, as it is more relevant to source-build