Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Array.Initialize in C# #77336
Implement Array.Initialize in C# #77336
Changes from 3 commits
8dcad5f
cf4ede4
08220af
97f72db
cd85e02
266378a
2407b33
003c215
cb435ce
ad26d52
07a28d7
a945257
ba27fd2
e1d6ec9
4b5a4ec
7988ae3
b0d6af6
be576ad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dotnet/ilc-contrib Should
Array.Initialize
be marked withRequiresUnreferenceCode
, or is the value type default constructor the special-cased by the trimmer and always preserved?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should:
dotnet run
prints out ".ctor called".But trimmed the app doesn't print out anything.
Related question - what should
default
do in this case, for example:Running it seems like it will NOT call the .ctor - but what does it do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same goes for AOT - published as Native AOT the app above also doesn't print out anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the specification,
default
ignores the parameterless constructor and generates a zeroed instance.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, adding
RequiresUnreferencedCode
onArray.Initialize
has a ripple effect. It introduces warnings in situations where array type is passed intoDynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)
.I guess it will need more careful thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #77426