Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] HttpStress do not use SYS_PTRACE cap for docker runs #77125

Merged
merged 5 commits into from
Nov 2, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 17, 2022

Backport of #76307 to release/7.0

/cc @antonfirsov

Customer Impact

This is a test-only change fixing an optional pipeline. Nightly stress-http runs are important for QA of the networking stack.

Testing

N/A

Risk

None

@ghost
Copy link

ghost commented Oct 17, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #76307 to release/7.0

/cc @antonfirsov

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@antonfirsov
Copy link
Member

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
Copy link
Member

@carlossanlop can we get this merged if the Windows bits of the stress-http run are passing?

@carlossanlop
Copy link
Member

Test-only, sure, I can merge it as tell-mode (no Tactics approval required). If we're confident stress-http is the only queue needed, we can wait for that check. Ping me when it's done.

Don't forget to provide a code review sign-off.

@antonfirsov
Copy link
Member

Test failures are #74838. stress-http passed, @carlossanlop this is save to merge now.

@karelz karelz requested a review from wfurt November 1, 2022 17:46
@karelz karelz added this to the 7.0.x milestone Nov 1, 2022
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonfirsov
Copy link
Member

Don't forget to provide a code review sign-off.

@carlossanlop oops I missed this little advice 😆 Should be good to go now!

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch is open for merging servicing changes. Failures were all unrelated. Ready to merge.

@carlossanlop carlossanlop merged commit 25caf20 into release/7.0 Nov 2, 2022
@carlossanlop carlossanlop deleted the backport/pr-76307-to-release/7.0 branch November 2, 2022 21:33
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants