Don't copy coreclr version of coreclr and SPCL to core_root when targeting mono

[elinor-fung]

Fixes #72114 (hopefully)

When generating core_root targeting mono, both the coreclr and mono versions of coreclr and System.Private.CoreLib.dll are being copied over. It is a race of which is last - when coreclr is last, it results in mass test failures due to the incorrectly constructed core_root.

[ghost]

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #72114 (hopefully)

Author:	elinor-fung
Assignees:	-
Labels:	area-Infrastructure-coreclr
Milestone:	-

[ghost]

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #72114 (hopefully)

When generating core_root targeting mono, both the coreclr and mono versions of coreclr are being copied over. It is a race of which is last - when coreclr is last, it results in mass test failures due to the incorrectly constructed core_root.

Author:	elinor-fung
Assignees:	elinor-fung
Labels:	area-Infrastructure
Milestone:	-

[jkoritzinsky]

I think we still need to copy over corerun for the Mono builds. It might be worth moving the source for corerun to somewhere under src/native so we can just include it in the Mono CMake build.

[elinor-fung]

Ugh, right. forgot that was from coreclr build/artifacts.

[elinor-fung]

Failure is #76801.

Checked the binlogs from the build to make sure we no longer have double writes when creating core_root for mono. We only copy the mono versions of coreclr and System.Private.CoreLib (not the coreclr ones).

[elinor-fung]

@dotnet/runtime-infrastructure anyone want to take a look here?

[trylek]

LGTM overall even though I probably still not fully grasp why you still seem to be copying around the CoreCLR version of coreclr.dll at line 178.

[elinor-fung]

still seem to be copying around the CoreCLR version of coreclr.dll at line 178

It's removing it from the items to copy. It currently gets included because we include the entire coreclr artifacts folder (parts of which we still need for mono) via wildcard, so that line removes that one file.