Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more PAL exports for wprintf wscanf funcs #76771

Merged
merged 4 commits into from
Oct 10, 2022
Merged

Remove more PAL exports for wprintf wscanf funcs #76771

merged 4 commits into from
Oct 10, 2022

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Oct 7, 2022 •
edited
Loading

Also removed swscanf_s.

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 8.0.0 milestone Oct 7, 2022
davidwrighton
davidwrighton approved these changes Oct 8, 2022
View reviewed changes
src/coreclr/pal/src/include/pal/palinternal.h Outdated Show resolved Hide resolved
src/coreclr/pal/src/cruntime/printf.cpp Show resolved Hide resolved
@AaronRobinsonMSFT AaronRobinsonMSFT changed the title Remove more PAL exports for wprintf funcs Remove more PAL exports for wprintf wscanf funcs Oct 8, 2022
@am11 am11 mentioned this pull request Oct 8, 2022
Open
@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review October 9, 2022 02:24
This was referenced Oct 10, 2022
Closed
Closed
Closed
janvorli
janvorli approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit a04f75c into dotnet:main Oct 10, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the remove_pal_funcs branch October 10, 2022 18:51
@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@am11 am11 am11 left review comments

@janvorli janvorli janvorli approved these changes

@davidwrighton davidwrighton davidwrighton approved these changes

Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels
area-VM-coreclr
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AaronRobinsonMSFT @am11 @janvorli @davidwrighton