Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Fix incorrect version comparison in loader #76665

Merged
merged 1 commit into from
Oct 6, 2022
Merged

[mono] Fix incorrect version comparison in loader #76665

merged 1 commit into from
Oct 6, 2022

Conversation

uweigand
Copy link
Contributor

@uweigand uweigand commented Oct 5, 2022

This should be backported to .NET 7 and .NET 6 as well.

@uweigand
[mono] Fix incorrect version comparison in loader
e126158 
* Compare version components in the correct order in
  assembly_names_compare_versions

* Fixes #76664
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 5, 2022
@ghost
Copy link

ghost commented Oct 5, 2022

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

This should be backported to .NET 7 and .NET 6 as well.

Author: uweigand
Assignees: -
Labels:

area-AssemblyLoader-mono
Milestone: -

@lambdageek
Copy link
Member

/backport to release/7.0

@lambdageek
Copy link
Member

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3194198853

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3194200068

@lambdageek
Copy link
Member

@akoeplinger this is probably worth porting to mono/mono 2020-02, as well

This was referenced Oct 6, 2022
Merged
Merged
@lambdageek lambdageek self-assigned this Oct 6, 2022
akoeplinger
akoeplinger approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Kind of amazing this got unnoticed so long 😄

@akoeplinger
Copy link
Member

/azp run sync-runtime-to-mono

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@akoeplinger
Copy link
Member

akoeplinger commented Oct 6, 2022 •
edited
Loading

hm looks like the sync pipeline got lost in the dnceng-public migration somehow. @uweigand would you mind manually porting this to mono/mono?

uweigand added a commit to uweigand/mono that referenced this pull request Oct 6, 2022
@uweigand
Fix incorrect version comparison in loader
95dd667 
* Backport dotnet/runtime#76665
@uweigand uweigand mentioned this pull request Oct 6, 2022
Merged
@uweigand
Copy link
Contributor Author

uweigand commented Oct 6, 2022

hm looks like the sync pipeline got lost in the dnceng-public migration somehow. @uweigand would you mind manually porting this to mono/mono?

mono/mono#21553

@akoeplinger akoeplinger merged commit 11b4ef9 into dotnet:main Oct 6, 2022
github-actions bot pushed a commit to mono/mono that referenced this pull request Oct 6, 2022
@uweigand
Fix incorrect version comparison in loader
49dea11 
* Backport dotnet/runtime#76665
akoeplinger pushed a commit to mono/mono that referenced this pull request Oct 6, 2022
@github-actions @uweigand
Fix incorrect version comparison in loader (#21554)
7cd0b7f 
* Backport dotnet/runtime#76665

Co-authored-by: Ulrich Weigand <[email protected]>
akoeplinger pushed a commit to mono/mono that referenced this pull request Oct 6, 2022
@uweigand
Fix incorrect version comparison in loader (#21553)
4cb02db 
* Backport dotnet/runtime#76665
@ghost ghost locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@vargaz vargaz Awaiting requested review from vargaz

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

Assignees

@lambdageek lambdageek

Labels
area-AssemblyLoader-mono community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mono] Incorrect version comparison in the loader
3 participants
@uweigand @lambdageek @akoeplinger