-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono] Fix incorrect version comparison in loader #76665
Conversation
* Compare version components in the correct order in assembly_names_compare_versions * Fixes #76664
Tagging subscribers to this area: Issue Details
This should be backported to .NET 7 and .NET 6 as well.
|
/backport to release/7.0 |
/backport to release/6.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3194198853 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3194200068 |
@akoeplinger this is probably worth porting to mono/mono 2020-02, as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find! Kind of amazing this got unnoticed so long 😄
/azp run sync-runtime-to-mono |
No pipelines are associated with this pull request. |
hm looks like the sync pipeline got lost in the dnceng-public migration somehow. @uweigand would you mind manually porting this to mono/mono? |
|
* Backport dotnet/runtime#76665 Co-authored-by: Ulrich Weigand <[email protected]>
Compare version components in the correct order in assembly_names_compare_versions
Fixes [mono] Incorrect version comparison in the loader #76664
This should be backported to .NET 7 and .NET 6 as well.