[release/7.0] Rename request count to permit count on System.Threading.RateLimiting #76623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #76558 to release/7.0
/cc @BrennanConroy @AliKhalili
Customer Impact
API is inconsistent with other rate limiters (ConcurrencyLimiter) and other APIs (the options refer to permits not requests), and not what was approved during API review. This can cause confusion. And we can't change this later as it is a source breaking change.
runtime/src/libraries/System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiterOptions.cs
Line 36 in dd6696a
Testing
N/A
Risk
Code using System.Threading.RateLimiting in previews, RC1, or RC2 may fail to compile after this change if using parameter names. e.g.
limiter.AttemptAcquireCore(requestCount: 3);
Fortunately, it'll be very easy to fix broken code, change
requestCount
topermitCount
.