Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hot_reload] Fix unresolved token when new nested structs are used #76618

Merged
merged 2 commits into from
Oct 5, 2022
Merged

[hot_reload] Fix unresolved token when new nested structs are used #76618

merged 2 commits into from
Oct 5, 2022

Commits on Oct 4, 2022

  1. [test] Calling the ctor of a class with a nested struct 

    This fails with

```
       Stack Trace:

          Child exception:
            System.BadImageFormatException: Could not resolve field token 0x04000014
          File name: 'System.Reflection.Metadata.ApplyUpdate.Test.ReflectionAddNewType'
          /Users/alklig/work/dotnet-runtime/runtime/src/libraries/System.Runtime.Loader/tests/ApplyUpdate/System.Reflection.Metadata.ApplyUpdate.Test.ReflectionAddNewType/ReflectionAddNewType.cs(29,0):
          at
          System.Reflection.Metadata.ApplyUpdate.Test.ReflectionAddNewType.ZExistingClass.ExistingMethod()

```
    @lambdageek
    lambdageek committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    6d2d4ee View commit details
    Browse the repository at this point in the history

  2. Don't resolve the types of added fields too early

    @lambdageek
    lambdageek committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    894cb89 View commit details
    Browse the repository at this point in the history