-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Make "Personal" on Android also point to a Documents folder #76250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dotnet#68610 moved `Personal`/`MyDocuments` on Unix systems from HOME to the documents folder. However, it didn't do so for Android systems, which was only noticed after tests later failed. This fixes it.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @dotnet/area-system-runtime Issue Details#68610 moved If this gets merged, dotnet/docs#31423 should get adjusted to include Android as well.
|
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
steveisok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Android tests now pass. Thanks for the PR!
mdh1418
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
eerhardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll update the breaking change doc once this is merged.
While looking at #76250 I noticed that we were querying the HOME env variable for SpecialFolder.UserProfile but we're already doing that in PersistedFiles.GetHomeDirectory()
While looking at #76250 I noticed that we were querying the HOME env variable for SpecialFolder.UserProfile but we're already doing that in PersistedFiles.GetHomeDirectory()
|
Updated dotnet/docs#31423 to include the Android behavior change. |
#68610 moved
Personal/MyDocumentson Unix systems from HOME to the documents folder. However, it didn't do so for Android systems, which was only noticed after tests later failed. This PR fixes it.If this gets merged, dotnet/docs#31423 should get adjusted to include Android as well.