Skip to content

Conversation

@Miepee
Copy link
Contributor

@Miepee Miepee commented Sep 27, 2022

#68610 moved Personal/MyDocuments on Unix systems from HOME to the documents folder. However, it didn't do so for Android systems, which was only noticed after tests later failed. This PR fixes it.

If this gets merged, dotnet/docs#31423 should get adjusted to include Android as well.

dotnet#68610 moved `Personal`/`MyDocuments` on Unix systems from HOME to the documents folder.
However, it didn't do so for Android systems, which was only noticed after tests later failed. This fixes it.
@ghost
Copy link

ghost commented Sep 27, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 27, 2022
@eerhardt eerhardt requested a review from steveisok September 27, 2022 15:10
@ghost
Copy link

ghost commented Sep 27, 2022

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

#68610 moved Personal/MyDocuments on Unix systems from HOME to the documents folder. However, it didn't do so for Android systems, which was only noticed after tests later failed. This PR fixes it.

If this gets merged, dotnet/docs#31423 should get adjusted to include Android as well.

Author: Miepee
Assignees: -
Labels:

area-System.Runtime, os-android, community-contribution

Milestone: -

@eerhardt
Copy link
Member

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android tests now pass. Thanks for the PR!

Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll update the breaking change doc once this is merged.

@akoeplinger akoeplinger merged commit a7d80c1 into dotnet:main Sep 28, 2022
akoeplinger added a commit that referenced this pull request Sep 28, 2022
While looking at #76250 I noticed that we were querying the HOME env variable for SpecialFolder.UserProfile but we're already doing that in PersistedFiles.GetHomeDirectory()
akoeplinger added a commit that referenced this pull request Sep 28, 2022
While looking at #76250 I noticed that we were querying the HOME env variable for SpecialFolder.UserProfile but we're already doing that in PersistedFiles.GetHomeDirectory()
@eerhardt
Copy link
Member

Updated dotnet/docs#31423 to include the Android behavior change.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtime community-contribution Indicates that the PR has been added by a community member os-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants