Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New ASCII APIs #75012

Merged
merged 51 commits into from
Dec 21, 2022
Merged

New ASCII APIs #75012

merged 51 commits into from
Dec 21, 2022

Commits on Jul 20, 2022

  1. Initial ASCII methods

    @GrabYourPitchforks
    GrabYourPitchforks committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    af2b950 View commit details
    Browse the repository at this point in the history

  2. Add transcoding APIs

    @GrabYourPitchforks
    GrabYourPitchforks committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    bd2b5f1 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. Implement Trim

    @GrabYourPitchforks
    GrabYourPitchforks committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    db37d32 View commit details
    Browse the repository at this point in the history

  2. Split ASCII utilities into separate files

    @GrabYourPitchforks
    GrabYourPitchforks committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    4a832cc View commit details
    Browse the repository at this point in the history

  3. Add ref asm

    @GrabYourPitchforks
    GrabYourPitchforks committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    e054a01 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. Fun with case conversion!

    @GrabYourPitchforks
    GrabYourPitchforks committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    36cbfa6 View commit details
    Browse the repository at this point in the history

  2. Fun with case conversion!

    @GrabYourPitchforks
    GrabYourPitchforks committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    bba61f5 View commit details
    Browse the repository at this point in the history

  3. Updates!

    @GrabYourPitchforks
    GrabYourPitchforks committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    89331d6 View commit details
    Browse the repository at this point in the history

  4. Fix incorrect comparison

    @GrabYourPitchforks
    GrabYourPitchforks committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    8333ec8 View commit details
    Browse the repository at this point in the history

  5. Fix incorrect precondition checks

    @GrabYourPitchforks
    GrabYourPitchforks committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    841fe3c View commit details
    Browse the repository at this point in the history

  6. Update main vectorized loop

    @GrabYourPitchforks
    GrabYourPitchforks committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    dce2cae View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2022

  1. Perf improvements & fix arithmetic error

    @GrabYourPitchforks
    GrabYourPitchforks committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    685b330 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. tests for Ascii.GetIndexOfFirstNonAsciiByte

    @adamsitnik
    adamsitnik committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    4914c65 View commit details
    Browse the repository at this point in the history

  2. tests for Ascii.GetIndexOfFirstNonAsciiChar

    @adamsitnik
    adamsitnik committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    7204d2d View commit details
    Browse the repository at this point in the history

  3. add tests for Ascii.IsAscii

    @adamsitnik
    adamsitnik committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    e3709b7 View commit details
    Browse the repository at this point in the history

  4. add tests for Ascii.FromUtf16

    @adamsitnik
    adamsitnik committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    fc6db59 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. add tests for Ascii.ToUtf16

    @adamsitnik
    adamsitnik committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    e316789 View commit details
    Browse the repository at this point in the history

  2. add tests for Ascii.Trim* and fix bug they have discovered

    @adamsitnik
    adamsitnik committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    a5f61b9 View commit details
    Browse the repository at this point in the history

  3. ToUpper & ToLower tests

    @adamsitnik
    adamsitnik committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    6516ae2 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. implement the missing pieces for case conversions + fix the tests

    @adamsitnik
    adamsitnik committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    6e1ca32 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into asciiAPIs

    @adamsitnik
    adamsitnik committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    5c90223 View commit details
    Browse the repository at this point in the history

  3. implement TryToLowerInPlace/TryToUpperInPlace

    @adamsitnik
    adamsitnik committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    4339af5 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. implement Ascii.StartsWith* and EndsWith* methods

    @adamsitnik
    adamsitnik committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    cc3be10 View commit details
    Browse the repository at this point in the history

  2. implement Ascii.Equals* methods

    @adamsitnik
    adamsitnik committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    ad4d90b View commit details
    Browse the repository at this point in the history

  3. use self-describing names at a cost of using pragma disable ;)

    @adamsitnik
    adamsitnik committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    adc2f53 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. throw ArgumentException with meaningful error message

    @adamsitnik
    adamsitnik committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    aad125a View commit details
    Browse the repository at this point in the history

  2. rename files

    @adamsitnik
    adamsitnik committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    f8f98ed View commit details
    Browse the repository at this point in the history

  3. Implement IndexOf and LastIndexOf using narrowing and widening

    @adamsitnik
    adamsitnik committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    2b2bcd1 View commit details
    Browse the repository at this point in the history

  4. Implement IndexOfIgnoreCase and LastIndexOfIgnoreCase

    @adamsitnik
    adamsitnik committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    2d9105e View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. refactoring

    @adamsitnik
    adamsitnik committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    cc603c7 View commit details
    Browse the repository at this point in the history

  2. IsAscii methods

    @adamsitnik
    adamsitnik committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    aff7e6e View commit details
    Browse the repository at this point in the history

  3. *GetHashCode(chars)

    @adamsitnik
    adamsitnik committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    bf5d709 View commit details
    Browse the repository at this point in the history

  4. *GetHashCode(bytes)

    @adamsitnik
    adamsitnik committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    ba1102d View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. solve buffer overrun: 8 chars need to be narrowed to 8 (not 16 like b… 

    …efore) bytes in case of ASCII case conversion
    @adamsitnik
    adamsitnik committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    0ffd3ee View commit details
    Browse the repository at this point in the history

  2. disable the tests that are failing due to Mono bug

    @adamsitnik
    adamsitnik committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    6f96b8b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into asciiAPIs

    @adamsitnik
    adamsitnik committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    8ab53c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. fix a bug (tests that are not compiled are always passing)

    @adamsitnik
    adamsitnik committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    3d5df19 View commit details
    Browse the repository at this point in the history

  2. use new APIs across BCL: 

    use Trim and EqualsIgnoreCase in CharArrayHelpers (used by System.Net.Http and System.Net.Http.WinHttpHandler)
use Equals in various System.Net.Http places
use EqualsIgnoreCase in CaseInsensitiveAscii (used by System.Net.WebHeaderCollection), force it's inlining
use TryToLowerInPlace in System.Net.HttpListener
use ToLower in QPackEncoder (used by System.Net.Http)
use IndexOf in Http2LoopbackConnection (used by System.Net.Http* test projects)
use IsAscii and FromUtf16 in PInvokeMarshal (NatvieAOT)
    @adamsitnik
    adamsitnik committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    518ef05 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Stephen Toub <[email protected]>
    @adamsitnik @stephentoub
    adamsitnik and stephentoub authored Sep 8, 2022
    Configuration menu
    Copy the full SHA
    ab12f70 View commit details
    Browse the repository at this point in the history

  2. address code review feedback

    @adamsitnik
    adamsitnik committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    29b38f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Merge remote-tracking branch 'upstream/main' into asciiAPIs 

    # Conflicts:
#	src/libraries/System.Private.CoreLib/src/System/Text/ASCIIUtility.cs
    @adamsitnik
    adamsitnik committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    bc48a30 View commit details
    Browse the repository at this point in the history

  2. fold ASCIIUtility into Ascii, use public APIs

    @adamsitnik
    adamsitnik committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    1edc812 View commit details
    Browse the repository at this point in the history

  3. fix tests that were relying on reflection so far (and I did not know … 

    …about their existence)
    @adamsitnik
    adamsitnik committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    e2d7105 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. fix byte->char casting

    @adamsitnik
    adamsitnik committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    6106659 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. adjust code after recent API Review

    @adamsitnik
    adamsitnik committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    0d69abd View commit details
    Browse the repository at this point in the history

  2. add missing XML docs

    @adamsitnik
    adamsitnik committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    bb0a272 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into asciiAPIs 

    # Conflicts:
#	src/libraries/System.Private.CoreLib/src/System/Globalization/TextInfo.cs
#	src/libraries/System.Private.Uri/src/System/DomainNameHelper.cs
#	src/libraries/System.Private.Uri/src/System/UriHelper.cs
    @adamsitnik
    adamsitnik committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    b1f1f07 View commit details
    Browse the repository at this point in the history

  4. cleanup

    @adamsitnik
    adamsitnik committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    c0f38d1 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. address code review feedback

    @adamsitnik
    adamsitnik committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    da94353 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into asciiAPIs

    @adamsitnik
    adamsitnik committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    b975fe1 View commit details
    Browse the repository at this point in the history

  3. Update src/libraries/System.Private.Uri/src/System/DomainNameHelper.cs 

    Co-authored-by: Miha Zupan <[email protected]>
    @adamsitnik @MihaZupan
    adamsitnik and MihaZupan authored Dec 9, 2022
    Configuration menu
    Copy the full SHA
    4483baf View commit details
    Browse the repository at this point in the history