-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0-rc1] [MONO] Make mono_marshal_ilgen_init a public MONO_API function again #74660
[release/7.0-rc1] [MONO] Make mono_marshal_ilgen_init a public MONO_API function again #74660
Conversation
We have a workaround in xamarin/xamarin-macios#15788 so if that lands this can be retargeted to |
@lewing not sure what will be faster, our CI started going 🍌s today :( so I would say if you can keep the train going on this one as a fail safe might be better |
I'm not stopping it but taking a new runtime package will put schedules at risk |
697be58
to
2045c58
Compare
@lewing Looks like we need this PR after all see: xamarin/xamarin-macios#15788 (comment)
|
@mmitche do we still have runway to get this merged to RC1? |
can't merge this as is, it breaks wasm. alternate fix staged in #74675 while we keep working on this |
Backport of #74658 to release/7.0-rc1
/cc @lewing @naricc
Customer Impact
Testing
Risk
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.