Fix setting weight for inverted loop condition block #74444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In stress scenarios with inconsistent weights, it was possible to change the condition weight from zero to non-zero without resetting the "rarely run" bit. Use `inheritWeight()` to set the weight, which handles this case. Fixes dotnet#74218
ghost
added
the
area-CodeGen-coreclr
Contributor
Author
|
@AndyAyersMS @dotnet/jit-contrib PTAL |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIn stress scenarios with inconsistent weights, it was possible Fixes #74218
|
AndyAyersMS
approved these changes
Aug 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In stress scenarios with inconsistent weights, it was possible
to change the condition weight from zero to non-zero without
resetting the "rarely run" bit. Use
inheritWeight()to setthe weight, which handles this case.
Fixes #74218