Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose JsonSerializer.IsReadOnly and MakeReadOnly() APIs. #74431

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

eiriktsarpalis
Copy link
Member

Fix #54482.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@eiriktsarpalis eiriktsarpalis added this to the 8.0.0 milestone Aug 23, 2022
@ghost ghost assigned eiriktsarpalis Aug 23, 2022
@ghost
Copy link

ghost commented Aug 23, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #54482.

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json, new-api-needs-documentation

Milestone: -

Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some small comments - I'll only ask to change the docs to not use word indempotent remaining comments fix as you see fit

@eiriktsarpalis eiriktsarpalis merged commit 4b14c92 into dotnet:main Aug 24, 2022
@eiriktsarpalis eiriktsarpalis deleted the jsonserializeroptions-lock branch August 24, 2022 14:06
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2022
@jeffhandley jeffhandley added the blog-candidate Completed PRs that are candidate topics for blog post coverage label Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json blog-candidate Completed PRs that are candidate topics for blog post coverage new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a public api to "lock" a JsonSerializerOptions
3 participants