-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport crossgen2 fix for musl-libc #73986
Conversation
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsCustomer ImpactOn the operating systems using musl-libc, some of the compiled binaries such as crossgen2 are linked with glibc and that forces the consumer to install glib on the system (which is unintended as rest of the artifacts are linked to musl-libc). The issue is that we are not taking libc flavor into account when calculating the OS value in 6.0. TestingThis fix is tested on 7.0. This fix was made during the addition of another libc flavor (bionic-libc), in order to diversify the OS calculation. I have done some sanity testing locally, but not the entire platform matrix which uses cross-building. I will wait for the CI results. RiskLow. When CI legs are green, that will indicate that the platforms for which we cross-compile and run tests in Helix are largely unaffected. However, we need to make sure that crossgen2 binary is in working condition on those platforms since we are lacking tests for cross-compiled, crossgen2 binary. Fixes #73908
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This is release/6.0 - we decided this change can wait for the next train. |
Branding has been completed, so the branch is open again for changes. Merging since it got approved. |
Customer Impact
On the operating systems using musl-libc, some of the compiled binaries such as crossgen2 were incorrectly linked with glibc and that forces the consumer to install glibc on those systems (which is unintended as rest of the runtime artifacts are linked to musl-libc). The issue is that we are not taking libc flavor into account when calculating the OS value in 6.0.
Testing
This fix is tested on 7.0. This fix was made during the addition of another libc flavor (bionic-libc), in order to diversify the OS calculation. I have done some sanity testing locally, but not the entire platform matrix which uses cross-building. I will wait for the CI results.
Risk
Low. When CI legs are green, that will indicate that the platforms for which we cross-compile and run tests in Helix are largely unaffected. However, we need to make sure that crossgen2 binary is in working condition on those platforms since we are lacking tests for cross-compiled, crossgen2 binary.
Fixes #73908