Bump main branding to 8.0 #73985
Bump main branding to 8.0 #73985
Conversation
carlossanlop
requested review from
ViktorHofer,
ericstj,
joperezr and
smasher164
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsDo not merge. This depends on snapping first. This PR is loosely based on what we did last year: https://github.com/dotnet/runtime/pull/57095/files I suspect this change is incomplete, since many of the elements modified in last year's PR do not exist today.
|
eng/Versions.props
Outdated
| <!-- Set assembly version to align with major and minor version, | ||
| as for the patches and revisions should be manually updated per assembly if it is serviced. --> | ||
| <AssemblyVersion>$(MajorVersion).$(MinorVersion).0.0</AssemblyVersion> | ||
| <AssemblyVersion>$(PreviousReleaseMajorVersion).$(MinorVersion).0.0</AssemblyVersion> |
There was a problem hiding this comment.
| <AssemblyVersion>$(PreviousReleaseMajorVersion).$(MinorVersion).0.0</AssemblyVersion> | |
| <AssemblyVersion>7.$(MinorVersion).0.0</AssemblyVersion> |
There was a problem hiding this comment.
I'll apply your suggestion, but can you please explain why this value can't stay in $(MajorVersion)? Why do we need to use 7 instead of 8?
There was a problem hiding this comment.
In the past release when we branded main to .NET 7 we didn't bump the assembly versions as part of the branding update. We only incremented the package major version to avoid bin clashes when packages being uploaded to the same feed.
Incrementing the assembly versions should happen afterwards to not block this PR: I assume that the assembly update could cause other issues that would need to be resolved.
Co-authored-by: Viktor Hofer <[email protected]>
carlossanlop
changed the title
|
@ViktorHofer any chance you can give a quick look at last year's PR and let me know if I missed anything? https://github.com/dotnet/runtime/pull/57095/files |
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
LGTM. Unsure if the SdkBandVersion needs to be incremented as well, but that can probably be done in a follow-up.
|
Ci failures unrelated. |
ghost
locked as resolved and limited conversation to collaborators
3 participants
Do not merge. This depends on snapping first.
This PR is loosely based on what we did last year: https://github.com/dotnet/runtime/pull/57095/files
I suspect this change is incomplete, since many of the elements modified in last year's PR do not exist today.