[wasm][debugger] Fix some racy tests #73524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. contains the assembly contents which can be large .
.. the updated method becomes callable, instead of `Thread.Sleep`.
… spot in test failures
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsSome of the hot reload tests fail randomly because they call the updated methods too early. Instead, wait for the Fixes #66024 .
|
.. and notification handlers, since they can be modified from different threads. Fixes dotnet#69144 .
radical
changed the title
|
The debugger test failure is #73528 . |
pavelsavara
reviewed
Aug 9, 2022
| @@ -215,6 +218,15 @@ async Task OnMessage(string method, JObject args, CancellationToken token) | |||
| default: _logger.LogInformation(line); break; | |||
| } | |||
|
|
|||
| if (!_gotAppReady && line == "console.debug: #debugger-app-ready#") | |||
thaystg
approved these changes
Aug 9, 2022
radical
added
the
NO-MERGE
- ChromeProvider starts the browser and then waits for a special string
which indicates that the browser is ready for connections.
- Firefox doesn't emit anything similar, so it waits for `console.log: ready`
message we get from `debugger-driver.html`.
- but since we wait for this in `FirefoxProvider`, when we start the
`Inspector` after this, the ready message is already gone, so it will
never see it.
- To avoid this, if we change the connection logic to instead
a. start the browser
b. wait till we can connect successfully
c. and then start `Inspector`, then it can still be too late if
the page starts up, and the message is emitted before the Inspector
was started.
- A proper fix would be to start the browser but with no url specified.
And once we establish a connection to it, *then* send a command to open
a url.
For now, we'll emit the old message `console.log: ready` too, just for
consumption by the firefox tests. And this can be fixed property in the
future.
radical
removed
the
NO-MERGE
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Fix random HotReload test failures
Some of the hot reload tests fail randomly because they call the updated methods too early.
The tests used
Thread.Sleep(3000)to wait for the method to get updated, and the proxyto respond to that. And that's essentially racy.
Instead, wait for the
breakpointResolvedevent, or thescriptParsedevents for the methods,as appropriate.
Fixes #66024
Fixes #72946
2. Fix race in adding/removing event handlers
Use ConcurrentDictionary for event listeners, and notification handlers, since they can be modified
from different threads.
Fixes #69144 .
3. Fix a race condition where the tests start calling methods before the app is ready
Fixes #73528