Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Enable ThreadPoolCanPickUpOneOrMoreWorkItemsWhenThreadIsAvailable test #73487

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

steveisok
Copy link
Member

Fixes #43754

@ghost
Copy link

ghost commented Aug 5, 2022

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #43754

Author: steveisok
Assignees: -
Labels:

area-System.Threading

Milestone: -

@mdh1418
Copy link
Member

mdh1418 commented Aug 5, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the test suite crashed previously based on #43754 (comment). Once we double check that the test suite runs and this test indeed passes, looks good!

@mdh1418
Copy link
Member

mdh1418 commented Aug 8, 2022

Looks like this test fails on just Android emulators

@mdh1418
Copy link
Member

mdh1418 commented Aug 9, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418
Copy link
Member

mdh1418 commented Aug 9, 2022

@akoeplinger Does the change to handle when there is 1 core look good to you?

@naricc naricc self-requested a review August 10, 2022 17:11
@mdh1418 mdh1418 merged commit ee5b738 into dotnet:main Aug 10, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThreadPoolCanPickUpOneOrMoreWorkItemsWhenThreadIsAvailable test failure on Android
3 participants