-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][debugger] Detect new
keyword in derived members on GetProperties
#73230
Conversation
Tagging subscribers to this area: @thaystg Issue DetailsFixes VHO case from #69788. On
This means that if we detect a change between parents in
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsFixes VHO case from #69788. On
This means that if we detect a change between parents in
|
/azp run runtime-staging |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #69788 (VHO case from there).
On
GetProperties
ofDerivedClass
type object we want to return correctly inherited members.NewSlot
values for sample hierarchy of entities are as follows:This means that if we detect a change between parents in
newSlot
value fromFalse
toTrue
, we should hide the member that has theTrue
value.Till this moment we were hiding all members that have
newSlot = True
which resulted in hiding both "B" and "BB" and was incorrect - "BB" should not be missing.