Add local build for System.Globalization shim

[smhmhmd]

Bundle the System.Globalization.Native shim sources into the native AOT toolchain package and compile them automatically using C/C++ compiler on the target machine.

Compiling of the shim sources using C/C++ compiler is done during dotnet publish as follows:
dotnet publish /p:LocalSystemGlobalizationNative=1 -bl -r linux-x64

This change is 'opt-in', it is enabled only by using /p:LocalSystemGlobalizationNative=1

[dnfadmin]

All CLA requirements met.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Bundle the System.Globalization.Native shim sources into the native AOT toolchain package and compile them automatically using C/C++ compiler on the target machine.

Compiling of the shim sources using C/C++ compiler is done during dotnet publish as follows:
dotnet publish /p:LocalSystemGlobalizationNative=1 -bl -r linux-x64

This change is 'opt-in', it is enabled only by using /p:LocalSystemGlobalizationNative=1

Author:	smhmhmd
Assignees:	-
Labels:	area-System.Globalization
Milestone:	-

[tarekgh]

CC @jkotas

[tarekgh]

#70848

[am11]

So far we have not required cmake dependency for PublishAot=tru on the user machine, I think it would be nice to keep it that way.

[jkotas]

So far we have not required cmake dependency for PublishAot=tru on the user machine, I think it would be nice to keep it that way

I do not think that cmake dependency is a problem for this special mode of NativeAOT publishing. This mode can grow into optionally building all C/C++ that the runtime is composed from.

[am11]

We can construct the same arguments in our existing msbuild targets which invokes the compiler, without requiring a fully fledged build system from user. It just feels heavy (even for this optional mode) as there is no system introspection going on only a few paths and macro definitions which can be passed with rest of the command line arguments.

[jkotas]

This should not be needed. The existing STATIC_ICU has the same effect - just need to define it when building.

Addressed in next revision

This does not seem to be addressed. pal_icushim_native_static.c file is still there.

[smhmhmd]

This should not be needed. The existing STATIC_ICU has the same effect - just need to define it when building.

Addressed in next revision

This does not seem to be addressed. pal_icushim_native_static.c file is still there.

Removed pal_icushim_native_static.c in latest revision

[Beau-Gosse-dev]

@smhmhmd and I both tested the recent commit across ARM64 and x64 with the below sample code, and were able to see that ulocdata_getCLDRVersion_66 was statically linked in the binary. As expected the resulting binary is much bigger with this new static linking. Up from 20MB unstripped to 50MB unstripped.

Published with ~/dotnet-sdk/dotnet publish /p:PublishAot=true /p:StaticICULinking=true -bl -r linux-arm64 --self-contained

namespace CurrentCulture
{
        class Program
        {
                static void Main(string[] args)
                {
                        double val = 1235.56;

                        Console.WriteLine($"Current culture: {CultureInfo.CurrentCulture.Name}");
                        Console.WriteLine(val);

                        CultureInfo.DefaultThreadCurrentCulture = new CultureInfo("en-US");

                        Console.WriteLine($"Current culture: {CultureInfo.CurrentCulture.Name}");
                        Console.WriteLine(val);
                }
        }
}

[jkotas]

One last thing: Could you please add a section "Using statically linked ICU" to https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/docs/compiling.md that documents this feature? (what it does and why one may want to use it, additional pre-requisites to install in addition to https://docs.microsoft.com/en-us/dotnet/core/deploying/native-aot/#prerequisites, etc.)

[smhmhmd]

Could you please add a section "Using statically linked ICU" to https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/docs/compiling.md that documents this feature

Thanks, I will add in next patch

[jkotas]

LGTM! Thank you for working on this!

@dotnet/ilc-contrib @dotnet/area-system-globalization Any additional feedback?

[MichalStrehovsky]

Looks great otherwise.

If you would like to make sure we're testing this configuration and it doesn't regress, add a test under src/tests/nativeaot/SmokeTests.

[smhmhmd]

If you would like to make sure we're testing this configuration and it doesn't regress, add a test under src/tests/nativeaot/SmokeTests.

Thanks, I will add a test under src/tests/nativeaot/SmokeTests