Skip to content

Remove IsPreRelease msbuild property #72169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2022
Merged

Remove IsPreRelease msbuild property #72169

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6cc5701
Remove IsPreRelease msbuild property
ViktorHofer Jul 14, 2022
4ad1f9b
Update configureplatform.cmake
ViktorHofer Jul 14, 2022
f9a0dd2
Update configureplatform.cmake
ViktorHofer Jul 14, 2022
d121854
Update configureplatform.cmake
ViktorHofer Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,6 @@
<Copyright>$(CopyrightNetFoundation)</Copyright>
<PackageThirdPartyNoticesFile>$(MSBuildThisFileDirectory)THIRD-PARTY-NOTICES.TXT</PackageThirdPartyNoticesFile>
<PackageReleaseNotes>https://go.microsoft.com/fwlink/?LinkID=799421</PackageReleaseNotes>
<!-- Indicates this is not an officially supported release. Release branches should set this to false. -->
<!-- Keep it in sync with PRERELEASE in eng/native/configureplatform.cmake -->
<IsPrerelease>false</IsPrerelease>
<IsPrivateAssembly>$(MSBuildProjectName.Contains('Private'))</IsPrivateAssembly>
<!-- Private packages should not be stable -->
<SuppressFinalPackageVersion Condition="'$(SuppressFinalPackageVersion)' == '' and $(IsPrivateAssembly)">true</SuppressFinalPackageVersion>
Expand Down
4 changes: 2 additions & 2 deletions eng/native/configureplatform.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
include(${CMAKE_CURRENT_LIST_DIR}/functions.cmake)

# If set, indicates that this is not an officially supported release
# Keep in sync with IsPrerelease in Directory.Build.props
# If set, indicates that this is not an officially supported release.
# Release branches should set this to false.
set(PRERELEASE 0)
Copy link
Member

@jkotas jkotas Jul 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be set to 1 in main?

Copy link
Member Author

@ViktorHofer ViktorHofer Jul 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was recently switched to 0 by @carlossanlop in 40b3c36. I already reached out to him offline and explained that this doesn't need to be set before we actually release.

Do you think we should switch it back and make sure that it again gets changed to 0 in the release/7.0 branch?

Copy link
Member

@jkotas jkotas Jul 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should switch it back and make sure that it again gets changed to 0 in the release/7.0 branch?

Yes.

If we switch it to 0 in main, we will see C/C++ compiler warnings creep in. I do not think anybody wants to sign up for fixing them once we fork for .NET 8.

Copy link
Member Author

@ViktorHofer ViktorHofer Jul 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.


#----------------------------------------
Expand Down