-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update runtime repo to use Preview 7 SDK #72145
Merged
Merged
Changes from 4 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d27729f
Update runtime repo to use Preview 6 SDK
agocke f276db3
Fix json encoding
agocke 0c66891
Use TrimMode=full instead of TrimmerDefaultAction
agocke 556bb8a
Also set TrimMode=full in TrimmingTests props file
agocke b40a841
Add TrimmerDefaultAction for NativeAOT library testing
agocke 5af1afa
Remove usage of default trim mode
agocke e1b012a
Replace with TrimMode partial
agocke 890efef
Merge remote-tracking branch 'upstream/main' into runtime-p6
agocke 2c4a9ca
Merge branch 'runtime-p6' of github.com:agocke/runtime into p7-sdk
jkoritzinsky b137f4d
Update SDK to preview 7
jkoritzinsky a3ee434
Merge branch 'main' of github.com:dotnet/runtime into p7-sdk
jkoritzinsky 8774ee3
Update Roslyn to 4.4.0-2.22412.11
hoyosjs 9d0508a
Merge remote-tracking branch 'upstream/main' into runtime-p6
AaronRobinsonMSFT 459a67a
Merge in main and update pgo project
AaronRobinsonMSFT 79ff97d
Add ByRefFields feature flag.
AaronRobinsonMSFT 99af1bd
Inline deleted ILLink.targets logic
MichalStrehovsky 6fa5900
Cleanups
MichalStrehovsky cedada9
Ensure no GC hole for LbrTraceEventData
jakobbotsch 17a4e22
Use static workaround since UnscopedRef is not yet available
jakobbotsch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<PropertyGroup> | ||
<TrimmerDefaultAction>link</TrimmerDefaultAction> | ||
<TrimMode>full</TrimMode> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We'll probably need to do the opposite here - nativeaot tests expect trimming and require the (now default) TrimMode=full. So this line is technically not needed. But the rest of the coreclr test tree will want to keep the partial TrimMode. |
||
</PropertyGroup> | ||
<Import Project="../Directory.Build.props" /> | ||
</Project> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this line if this is now the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we don't, I was just being explicit.