Polyfill the incremental generator ForAttributeWithMetadataName from roslyn (for JsonGenerator). #71653
Conversation
…roslyn (for JsonGenerator).
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsFollowup to #70911
|
| return typeGenerationSpec; | ||
| } | ||
|
|
||
| internal static bool IsSyntaxTargetForGeneration(SyntaxNode node) => node is ClassDeclarationSyntax { AttributeLists.Count: > 0, BaseList.Types.Count: > 0 }; |
There was a problem hiding this comment.
moved into the 3.11 source as that's the only place this is used now.
|
|
||
| if (fullName == JsonSerializableAttributeFullName) | ||
| { | ||
| return classDeclarationSyntax; |
There was a problem hiding this comment.
note: Teh only check we did was that hte fully qualified name is what we want. that's exactly what roslyn now does, so we need no additional semantic checks once we move to the roslyn api.
| _pos--; | ||
| return _span[_pos]; | ||
| } | ||
| } |
There was a problem hiding this comment.
There was a problem hiding this comment.
Not sure I understand the purpose of this file. If it's a dependency for the added Roslyn helpers, why can't it just live inside $CommonPath?
There was a problem hiding this comment.
It def can, and i've made that change in #71652. I'll port that over to this one.
|
cc @eiriktsarpalis @layomia @krwq @ericstj PTAL. For context, @CyrusNajmabadi is helping us add a much more performant way for source generators that depend on Attributes to run, and with these PRs he is onboarding generators one-by-one. Since you are the owners of the Json Source generator, do you mind taking a look at the changes and make sure they makes sense? |
src/libraries/System.Text.Json/src/System/Collections/Generic/ValueListBuilder.Pop.cs
Show resolved
Hide resolved
eiriktsarpalis
left a comment
eiriktsarpalis
left a comment
There was a problem hiding this comment.
LGTM other than a couple of comments.
src/libraries/System.Text.Json/gen/System.Text.Json.SourceGeneration.Roslyn4.0.csproj
Outdated
Show resolved
Hide resolved
…ration.Roslyn4.0.csproj
|
Related to #68353. |
ghost
locked as resolved and limited conversation to collaborators
3 participants
Followup to #70911