-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Polyfill the incremental generator ForAttributeWithMetadataName from roslyn (for LibraryImportGenerator). #71652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
498b5e6
Polyfill the incremental generator ForAttributeWithMetadataName from …
CyrusNajmabadi 6cade39
Move common code to shared location
CyrusNajmabadi 6ed1066
Update projects
CyrusNajmabadi 65fbf2d
Update Roslyn version for the generators that ship with the ref pack …
jkoritzinsky f8754d6
Merge remote-tracking branch 'upstream/main' into libraryImport
CyrusNajmabadi c5ff411
Update the version of Roslyn that the tests reference to match at lea…
jkoritzinsky 85a9e24
Merge branch 'main' into libraryImport
CyrusNajmabadi 39a4528
Merge remote-tracking branch 'upstream/main' into libraryImport
CyrusNajmabadi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
...ies/System.Runtime.InteropServices/src/System/Collections/Generic/ValueListBuilder.Pop.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System.Runtime.CompilerServices; | ||
|
|
||
| namespace System.Collections.Generic | ||
| { | ||
| /// <summary> | ||
| /// These public methods are required by RegexWriter. | ||
| /// </summary> | ||
| internal ref partial struct ValueListBuilder<T> | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public T Pop() | ||
| { | ||
| _pos--; | ||
| return _span[_pos]; | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.