Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fold TYP_STRUCT indirect access to promoted locals #71584

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Fold TYP_STRUCT indirect access to promoted locals #71584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/coreclr/jit/lclmorph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,17 +993,17 @@ class LocalAddressVisitor final : public GenTreeVisitor<LocalAddressVisitor>
return IndirTransform::None;
}

if (varDsc->lvPromoted)
{
// TODO-ADDR: For now we ignore promoted variables, they require additional
// changes in subsequent phases.
return IndirTransform::None;
}

// As we are only handling non-promoted STRUCT locals right now, the only
// possible transformation for non-STRUCT indirect uses is LCL_FLD.
if (!varTypeIsStruct(indir))
{
if (varDsc->lvPromoted)
{
// TODO-ADDR: support promoted locals here by moving the promotion morphing
// from pre-order to post-order.
return IndirTransform::None;
}

// As we are only handling non-promoted STRUCT locals right now, the only
// possible transformation for non-STRUCT indirect uses is LCL_FLD.
assert(varDsc->TypeGet() == TYP_STRUCT);
return IndirTransform::LclFld;
}
Expand Down