Simplify NtProcessInfoHelper.GetProcessShortName #71136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code was iterating character by character through the name, looking for the last occurrence of a slash and the last occurrence of a period. For the slash, we can just LasIndexOfAny. For the period, it was only doing this in order to trim off ".exe" if a period was found and the text at that point was ".exe"... so we can just compare the end with ".exe".
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process Issue DetailsThe previous code was iterating character by character through the name, looking for the last occurrence of a slash and the last occurrence of a period. For the slash, we can just LasIndexOfAny. For the period, it was only doing this in order to trim off ".exe" if a period was found and the text at that point was ".exe"... so we can just compare the end with ".exe".
|
gfoidl
reviewed
Jun 22, 2022
| { | ||
| slash++; // point to character next to slash | ||
| name = name.Slice(0, name.Length - 4); |
There was a problem hiding this comment.
Suggested change
| name = name.Slice(0, name.Length - 4); | |
| name = name[..^4]; |
jkotas
approved these changes
Jun 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code was iterating character by character through the name, looking for the last occurrence of a slash and the last occurrence of a period. For the slash, we can just LasIndexOfAny. For the period, it was only doing this in order to trim off ".exe" if a period was found and the text at that point was ".exe"... so we can just compare the end with ".exe".