Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing AcosPi, AsinPi, Atan2Pi, AtanPi, CosPi, SinPi, and TanPi for ITrigonometricFunctions #71033

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Exposing AcosPi, AsinPi, Atan2Pi, AtanPi, CosPi, SinPi, and TanPi for ITrigonometricFunctions #71033

merged 3 commits into from
Jun 22, 2022

Conversation

tannergooding
Copy link
Member

This exposes the AcosPi, AsinPi, Atan2Pi, AtanPi, CosPi, SinPi, and TanPi functions approved for the ITrigonometricFunctions interface.

TODO

[ ] - Add tests for Atan2Pi

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned tannergooding Jun 21, 2022
@ghost
Copy link

ghost commented Jun 21, 2022

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

This exposes the AcosPi, AsinPi, Atan2Pi, AtanPi, CosPi, SinPi, and TanPi functions approved for the ITrigonometricFunctions interface.

TODO

[ ] - Add tests for Atan2Pi

Author: tannergooding
Assignees: tannergooding
Labels:

area-System.Numerics, new-api-needs-documentation
Milestone: -

@huoyaoyuan
Copy link
Member

In #53675 I added tests for +-0/Inf etc from IEEE754 spec.

adamsitnik
adamsitnik approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @tannergooding !

@tannergooding tannergooding merged commit 0855da7 into dotnet:main Jun 22, 2022
@tannergooding
Copy link
Member Author

Going to finish adding the Atan2 tests in follow up PR so this makes the snap.

@tannergooding tannergooding mentioned this pull request Jun 23, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gfoidl gfoidl gfoidl left review comments

@adamsitnik adamsitnik adamsitnik approved these changes

Assignees

@tannergooding tannergooding

Labels
area-System.Numerics new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tannergooding @huoyaoyuan @gfoidl @adamsitnik