Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TYP_STRUCT LCL_VAR/LCL_FLD call args on Unix x64 #70960

Merged

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Jun 19, 2022

Same as #70777, but for Unix x64.

We have pretty similar (nice) diffs.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 19, 2022
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 19, 2022
@ghost
Copy link

ghost commented Jun 19, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Same as #70777, but for Unix x64.

We're expecting pretty comparable (nice) diffs.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@SingleAccretion SingleAccretion force-pushed the Struct-LclFld-Args-Unix-x64-Upstream branch from 4e93dfa to 84619e6 Compare June 19, 2022 21:23
Required to avoid regressions due to args sorting.
@SingleAccretion SingleAccretion force-pushed the Struct-LclFld-Args-Unix-x64-Upstream branch from 84619e6 to 6b50969 Compare June 20, 2022 10:49
@SingleAccretion SingleAccretion marked this pull request as ready for review June 20, 2022 18:28
@SingleAccretion
Copy link
Contributor Author

Installer Build and Test coreclr windows_x86 Debug) failure is #70969.

@dotnet/jit-contrib

@jakobbotsch jakobbotsch merged commit 34d5286 into dotnet:main Jun 23, 2022
@SingleAccretion SingleAccretion deleted the Struct-LclFld-Args-Unix-x64-Upstream branch June 23, 2022 10:48
@ghost ghost locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants