Enable TYP_STRUCT LCL_VAR/LCL_FLD call args on x86
#70779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsDepends on #70777.
|
Closed
SingleAccretion
changed the title
TYP_STRUCT LCL_VAR/LCL_FLD call args on x86TYP_STRUCT LCL_VAR/LCL_FLD call args on x86
SingleAccretion
force-pushed
the
Struct-LclFld-Args-x86
branch
from
1a9984d
to
bd112ab
Compare
SingleAccretion
force-pushed
the
Struct-LclFld-Args-x86
branch
from
bd112ab
to
5e77628
Compare
|
@dotnet/jit-contrib |
jakobbotsch
approved these changes
Jun 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diffs are for pretty much the same reasons as in #70777 (comment), the one difference being that there are a lot of regressions in libraries tests.
I have analyzed them, and the large number is due to the fact they're coming from the numerous
MoveNextmethods on async state machines. All have a singular cause: we don't set DNER on a small struct argument (which by itself is good) and this causes the RA to not enregister another local.