[mono][wasm] Add a 'wasm-gc-safepoints' option to enable the generati… #70520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
…on of GC safe points in AOTed code on WASM.
lambdageek
reviewed
Jun 9, 2022
| @@ -531,6 +531,7 @@ | |||
| <MonoAOTCompilerDefaultAotArguments Include="deterministic" /> | |||
| <MonoAOTCompilerDefaultAotArguments Include="mattr=simd" Condition="'$(WasmSIMD)' == 'true'" /> | |||
| <MonoAOTCompilerDefaultProcessArguments Include="--wasm-exceptions" Condition="'$(WasmExceptionHandling)' == 'true'" /> | |||
| <MonoAOTCompilerDefaultProcessArguments Include="--wasm-gc-safepoints" Condition="'$(WasmEnableThreads)' == 'true' or '$(WasmEnablePerfTracing)' == 'true'" /> | |||
There was a problem hiding this comment.
Actually what do we want this to do:
- pick up the flag from how
build.sh --os browserwas running? - or pick up the property from what the user app build is doing?
I think right now it's from whatever the user passes when doing the app build.
I think that's probably what we want.
lambdageek
approved these changes
Jun 9, 2022
40 tasks
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Failures are unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on of GC safe points in AOTed code on WASM.