Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement UnixFileMode APIs #69980
Implement UnixFileMode APIs #69980
Changes from 6 commits
11c2422
b182b4d
f143499
5138601
4d6c524
813e24a
7bd2ae3
d67d738
3841bfb
d1e7ea8
f7db626
88828a4
cd4104f
c937c28
a12832c
d294651
3df946a
f3c55bf
91e0891
6e74d98
757c1e5
53539ec
873660e
d9c7789
3dba808
33d3e6f
18e70c9
b2423c6
777b77d
4e93e11
60d24a7
8f8ff2d
97df035
7bfa541
01f6ff3
6e91cf1
4cb6316
7046ea9
e55011d
bc7383b
d1f043d
168bdf5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these methods throw
PlatformNotSupportedException
on Windows, I think that it would be good to include this information in the docs./// <exception cref="PlatformNotSupportedException">Not supported on Windows.</exception>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it need to be added when it is marked with the
UnsupportedOSPlatformAttribute
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@buyaa-n what is the guidance for such scenarios?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk what is the guidance for documenting, though I know that the attribute would showed up on the API doc like this:
https://docs.microsoft.com/en-us/dotnet/api/system.console.in?view=net-6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only seeing 11 places that do this in the current codebase, but we throw PNSE in many, many other places. So I'm not sure this is strictly necessary.