Do not recost and rethread trees inside optRemoveRangeCheck
#69895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All but one caller of the method (RangeCheck) already do so in their "for (GenTree* node : stmt->TreeList())" loops, so it is not necessary. Additionally, re-threading the statement, when combined with "gtSetEvalOrder", can have the consequence of redirecting said loops, possibly causing them to miss some trees, which was observed in early propagation when working on removing "GT_INDEX". A few small diffs because we no longer recost when removing range checks in loop cloning, which is generally not necessary because cloning runs before the "global" costing is performed, except there is one quirk in "gtSetEvalOrder" which was looking as "compCurStmt", and that is not set during "fgSetBlockOrder".
Gets us back 0.13% (!!!) instructions according to PIN.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT Issue Details
|
|
@dotnet/jit-contrib |
BruceForstall
approved these changes
May 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All but one caller of the method (RangeCheck) already do so in their
for (GenTree* node : stmt->TreeList())loops, so it is not necessary.Additionally, re-threading the statement, when combined with
gtSetEvalOrder, can have the consequence of redirecting said loops, possibly causing them to miss some trees, which was observed in early propagation when working on removingGT_INDEX.A few small diffs because we no longer recost when removing range checks in loop cloning, which is generally not necessary because cloning runs before the "global" costing is performed, except there is one quirk in
gtSetEvalOrderwhich was looking atcompCurStmt, and that is not set duringfgSetBlockOrder.Diffs.