-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][debugger] Added support for getting members of static structures. #69542
[wasm][debugger] Added support for getting members of static structures. #69542
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsFixes #68539. Changes in this PR:
|
0689396
to
26f45c5
Compare
/azp run runtime-staging |
Azure Pipelines successfully started running 1 pipeline(s). |
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
Azure Pipelines successfully started running 1 pipeline(s). |
@ilonatommy is this waiting on review now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the feedback, it looks good.
In a future PR - static members in base/derived classes .
There is a test failure:
|
Looking at the docs:
So, if it's assembly then Instead, we should do it like:
This checks the exact value instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one needed change remaining - #69542 (comment) .
Other than that, LGTM 👍
Azure Pipelines successfully started running 1 pipeline(s). |
Fixes #68539.
Changes in this PR:
Members of static valueTypes are now being returned on
getProperties
, before they were skipped. To do it, flagincludeStatic=true
was added to the data flow.For static properties, to get values we need to invoke them. Because they are static, we cannot invoke getter using
objectId
, we have to usetypeId
instead. This change was made inGetNotAutoExpandableObject
where we put different values incontainerId
, conditioned by property being static. We have to save the information if getter is static inJObject
to skip writingElementType
to the buffer inInvokeMethod
- for statics runtime does not expect such information.Changed the expected result in
CallFunctionOnTests.PropertyGettersTest
. Previously properties of static classes were skipped in the reply togetProperties
. It was not the planned behavior so in this PR they are added to the reply as well.Changed the expected number of fields for
MiscTest.InspectTaskAtLocals
- now we expect 4 statics to be there as well:Smaller changes: removed whitespaces in Browsable tests classes to match automatic formatting, renamed Browsable test classes to be more descriptive, added missing test cases for static non-autoproperties in classes and structures.