-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure the shared framework build uses the generated runtime.json #69455
Conversation
@@ -221,6 +221,6 @@ | |||
ResolveLibrariesRuntimeFilesFromLocalBuild" /> | |||
|
|||
<PropertyGroup> | |||
<BundledRuntimeIdentifierGraphFile>$(RuntimeIdGraphDefinitionFile)</BundledRuntimeIdentifierGraphFile> | |||
<BundledRuntimeIdentifierGraphFile>$(LiveRuntimeIdGraphDefinitionFile)</BundledRuntimeIdentifierGraphFile> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By switching to the live generated runtime.json file, you are depending on the file already being generated which isn't the case until the Microsoft.NETCore.Platforms project is built. We should make sure that any code path that depends on it has a dependency to the Platforms project.
Closing this as I don't have cycles to drive it at the moment. @tmds feel free to fix this as it best fits the work you're doing. |
@ericstj the minimal thing we need for source-build is: have the non-portable rid show up in |
There are two places that generate a shared framework deps file. One is runtime/src/libraries/pretest.proj Line 97 in 1f1231c
The other is the shared framework SDK which uses the |
Fixes #53550