Skip to content

[Draft] Fix hard link creation in tar tests in Android, iOS, tvOS #69416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[Draft] Fix hard link creation in tar tests in Android, iOS, tvOS #69416

wants to merge 3 commits into from

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented May 17, 2022 •
edited
Loading

Fixes #68360

My suspicion is that in Android, iOS and tvOS (the only Unix platforms where this test failed) need to be elevated so the hardlink can be created.

My suspicion was wrong. We cannot elevate in those platforms.

In Android, it's not possible to create hard links so we should skip in that platform.

In iOS/tvOS we should be able to, but the logic that generated the "sanitized" path was not generating it correctly.

@carlossanlop carlossanlop added this to the 7.0.0 milestone May 17, 2022
@carlossanlop carlossanlop self-assigned this May 17, 2022
@ghost
Copy link

ghost commented May 17, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #68360

My suspicion is that in Android, iOS and tvOS (the only Unix platforms where this test failed) need to be elevated so the hardlink can be created.

Draft since I need to test this hypothesis in the CI first.

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-System.IO
Milestone: 7.0.0

@carlossanlop
Copy link
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced May 17, 2022
Open
Closed
@carlossanlop
Copy link
Contributor Author

/azp run runtime-extra-platforms

@carlossanlop carlossanlop marked this pull request as ready for review May 18, 2022 00:57
@carlossanlop carlossanlop changed the title [Draft] Fix hard link creation in tar tests in Android, iOS, tvOS Fix hard link creation in tar tests in Android, iOS, tvOS May 18, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop carlossanlop marked this pull request as draft May 18, 2022 19:30
@carlossanlop carlossanlop changed the title Fix hard link creation in tar tests in Android, iOS, tvOS [Draft] Fix hard link creation in tar tests in Android, iOS, tvOS May 18, 2022
@carlossanlop
Change GetSanitizedFulPath logic to first combine paths before saniti…
744e088 
…zation, mavoid locaal method to improve stacktrace.
@carlossanlop
Skip Android hardlink creation test, make sure to use Pax format due …
9a61a82 
…to potential long paths when extracting to temp dir.
@carlossanlop
Copy link
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Contributor Author

The test was recently disabled in LinuxBionic. I need to see the CI results to determine what to do there.

jkotas
jkotas reviewed May 22, 2022
View reviewed changes
@carlossanlop
Copy link
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Contributor Author

The runtime-extra-platforms pipeline was failing instantly after executing it due to some external widespread problem. Running again.

@carlossanlop
Copy link
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop carlossanlop marked this pull request as ready for review May 28, 2022 03:28
@carlossanlop
Copy link
Contributor Author

This PR will end up fixing two bugs. Will resubmit soon.

@carlossanlop carlossanlop deleted the Fix68360 branch June 16, 2022 17:01
@ghost ghost locked as resolved and limited conversation to collaborators Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas left review comments

@eerhardt eerhardt eerhardt left review comments

@jozkee jozkee Awaiting requested review from jozkee

@adamsitnik adamsitnik Awaiting requested review from adamsitnik

Assignees

@carlossanlop carlossanlop

Labels

area-System.Formats.Tar

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Extract_HardLinkEntry_TargetInsideDirectory test from System.Formats.Tar.Tests fails on Android/iOS/tvOS

3 participants

@carlossanlop @jkotas @eerhardt