Call simpler overloads of Substring and Slice

[GrabYourPitchforks]

Minor code simplification which looks for places where we have code utilizing one of the following patterns:

someString.Substring(newOffset, someString.Length - newOffset);
someSpan.Slice(newOffset, someSpan.Length - newOffset);

And calls the single-parameter overload instead:

someString.Substring(newOffset);
someSpan.Slice(newOffset);

In particular, I did not try to improve the perf of the call sites, such as changing from an allocating call to an allocation-free call, etc. This is just a code simplification and doesn't try to change any of the logic.

[ghost]

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Minor code simplification which looks for places where we have code utilizing one of the following patterns:

someString.Substring(newOffset, someString.Length - newOffset);
someSpan.Slice(newOffset, someSpan.Length - newOffset);

And calls the single-parameter overload instead:

someString.Substring(newOffset);
someSpan.Slice(newOffset);

Author:	GrabYourPitchforks
Assignees:	-
Labels:	area-Meta
Milestone:	-

[stephentoub]

Looks like fodder for another analyzer.

[GrabYourPitchforks]

Looks like fodder for another analyzer.

Pondered that while doing this, but it's not really a perf gain. It's more of a code readability thing. Do we have good examples of analyzers in that category today?

Edit: I put up the analyzer proposal. I submit to the mercy of the analyzer gods to hash it out. :)

[GrabYourPitchforks]

/azp run runtime

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[GrabYourPitchforks]

CI failures are known issue #68939.