Skip to content

add architecture enum PPC64le #68809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akoeplinger merged 2 commits into from
Jun 13, 2022
Merged

add architecture enum PPC64le #68809

akoeplinger merged 2 commits into from
Jun 13, 2022

Conversation

@Sapana-Khemkar
Copy link
Contributor

@Sapana-Khemkar Sapana-Khemkar commented May 3, 2022 •
edited by akoeplinger
Loading

Add architecture enum for PPC64le. API proposal request raised here

Fixes #67428

@ghost ghost added community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation and removed community-contribution Indicates that the PR has been added by a community member labels May 3, 2022
@ghost
Copy link

ghost commented May 3, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented May 3, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@Sapana-Khemkar Sapana-Khemkar mentioned this pull request May 3, 2022
Closed
This was referenced May 3, 2022
Merged
Closed
@vikasgupta8 vikasgupta8 mentioned this pull request May 10, 2022
Merged
@ghost
Copy link

ghost commented May 29, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Add architecture enum for PPC64le. API proposal request raised here

Author: Sapana-Khemkar
Assignees: -
Labels:

area-System.Runtime.InteropServices, new-api-needs-documentation
Milestone: -

@Sapana-Khemkar
Copy link
Contributor Author

Sapana-Khemkar commented May 31, 2022

@AaronRobinsonMSFT @jkoritzinsky Can you please review this?

@directhex
Copy link
Contributor

directhex commented Jun 10, 2022

Per API review, please change this so only the first P is capitalised, i.e. Ppc64le

@AaronRobinsonMSFT AaronRobinsonMSFT added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jun 10, 2022
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jun 13, 2022
@Sapana-Khemkar
Copy link
Contributor Author

Sapana-Khemkar commented Jun 13, 2022

Per API review, please change this so only the first P is capitalised, i.e. Ppc64le

done

@akoeplinger akoeplinger merged commit e4aba62 into dotnet:main Jun 13, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@tannergooding tannergooding tannergooding approved these changes

Assignees

No one assigned

Labels

arch-ppc64le area-System.Runtime.InteropServices new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add architecture PPC64le to Architecture enum

6 participants

@Sapana-Khemkar @directhex @akoeplinger @tannergooding @jeffhandley @AaronRobinsonMSFT